Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid email addresses are rejected #1343

Closed
paulmenzel opened this issue Sep 10, 2024 · 2 comments
Closed

Valid email addresses are rejected #1343

paulmenzel opened this issue Sep 10, 2024 · 2 comments

Comments

@paulmenzel
Copy link

On rally.co participant in a survey and enter an email address containing / and ~ in the local part. Such an email is incorrectly rejected, for example a+rally.co~/@example.net.

@chrhi
Copy link

chrhi commented Sep 20, 2024

Thanks for pointing this out! It looks like the current validation might be stricter than necessary, as / and ~ can technically be valid characters in the local part of an email address according to the email standards (RFC 5321/5322).

It might be worth revisiting the email validation logic to accommodate these characters. This would allow users to input email addresses that are valid but currently rejected. Just wanted to bring this up in case the maintainers want to address it. Appreciate the great work on the project!

@lukevella
Copy link
Owner

lukevella commented Sep 20, 2024

We use zod for email validation and I believe I've found the reason for this issue here: colinhacks/zod#2157

This is also the reason why it won't be fixed as I have no plans to implement and maintain my own email validation. So I apologize for not being able to use your favorite email address with Rallly 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants