Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ico support #3

Closed
shanebo opened this issue Nov 16, 2021 · 1 comment
Closed

.ico support #3

shanebo opened this issue Nov 16, 2021 · 1 comment

Comments

@shanebo
Copy link

shanebo commented Nov 16, 2021

It'd be great if .ico was support out of the box. Thankfully you expose the mimes table, but it'd be great for this common extension to be natively mapped to the image/x-icon content type. Thanks for considering and for this great package!

@lukeed
Copy link
Owner

lukeed commented Nov 17, 2021

Hey, thanks!

All experimental types (x-*) and vendor-specific types are ignored. Making exceptions here and there is a slippery slope and the dividing line becomes less clear.

You can add this in to your own dictionary by directly assigning it. There's an example in the readme and throughout the tests.

Sorry but please do use the assignment approach! That was an intentional part of the pkg design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants