-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignore case for sorting #112
Conversation
Resolved these issues and linting passed locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks pretty good already 👌
Are there any further changes you would like to see? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good, sorry for the delay 👍
Released with v2.10.0 |
No worries on delay and thanks for the great plugin! Just installed 2.10.0 locally and added
My apologies, I missed the ("ignore_case", config_options.Type(bool, default=False)), |
Added option to ignore case for sorting pages.
Similar to previous PR, but added
ignore_case
as an option in theMeta
andOption
classes. Furthermore, modified the_order
method so thatignore_case
should work for natural and standard sorting.