Skip to content

Commit d607cfd

Browse files
author
Aaron Judd
committedApr 3, 2015
Merge pull request #120 from spencern/development
Update docs with notes about testing and deployment.
2 parents 55ec259 + 844e219 commit d607cfd

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed
 

‎docs/conventions.md

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ In the meantime we are testing reaction-core and other core packages with Veloci
3434

3535
A few things you should know:
3636
* First you'll need to uncomment `mike:mocha` and `sanjo:jasmine` in the `/.meteor/packages` file in the main meteor app.
37+
* You should set your `NODE_ENV` enviornment variable to 'development' to open up ports that velocity uses. The easiest way to do this is to run `export NODE_ENV="development"` before you start `meteor`
3738
* After doing that, your Velocity tests should run when you run `meteor run`
3839
* If you change or update the file structure in your `/tests` folder you may need to delete your `/packages/tests-proxy` directory. [This is a known issue with sanjo:jasmine](https://github.com/meteor-velocity/node-soft-mirror/issues/9#issuecomment-74386394)
3940
* If you run `meteor --test` your tests will only run once and will not re-run when you update files.

‎docs/deploying.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ The `Dockerfile` in the project root creates a Docker image of Reaction Commerce
1313
We provide release images built from the master branch. These are the same images running on reactioncommerce.com. You can pull our latest build from the [Docker Hub](https://registry.hub.docker.com/u/ongoworks/reaction/), or from the Reaction directory you can build your own Docker image:
1414

1515
```bash
16-
docker build -t reactioncommerce/reaction-test.
16+
docker build -t reactioncommerce/reaction-test .
1717
```
18+
Note: if building your own, comment out test packages before building (`mike:mocha` and `sanjo:jasmine`)
1819

1920
Start a Docker/Reaction container using [`docker run`](https://docs.docker.com/reference/commandline/cli/#run):
2021

0 commit comments

Comments
 (0)