-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined property Error in executeAutoPipeline #1425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen in an uncaughtException handler. ``` err_type=uncaughtException, exiting cause=TypeError: Cannot read property 'Symbol(callbacks)' of undefined at Immediate.executeAutoPipeline (.../node_modules/ioredis/built/autoPipelining.js:34:31) at Shim.applySegment (.../node_modules/newrelic/lib/shim/shim.js:1430:20) at Immediate.wrapper (.../node_modules/newrelic/lib/shim/shim.js:2097:17) at processImmediate (internal/timers.js:463:21) ``` A similar error was among the errors reported in redis#1248 I suspect the process.exec might call the callback synchronously in the same tick in some cases, immediately deleting the autopipeline from running pipelines?
TysonAndre
changed the title
Fix undefined property warning in executeAutoPipeline
Fix undefined property Error in executeAutoPipeline
Aug 27, 2021
This is ready for review. Any comments? |
ioredis-robot
pushed a commit
that referenced
this pull request
Aug 30, 2021
🎉 This PR is included in version 4.27.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.27.9](redis/ioredis@v4.27.8...v4.27.9) (2021-08-30) ### Bug Fixes * Fix undefined property warning in executeAutoPipeline ([#1425](redis/ioredis#1425)) ([f898672](redis/ioredis@f898672)) * improve proto checking for hgetall [skip ci] ([#1418](redis/ioredis#1418)) ([cba83cb](redis/ioredis@cba83cb))
This was referenced Jul 18, 2024
This was referenced Jul 29, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen in an uncaughtException handler with ioredis 4.27.7
The application having this issue has a constant&high volume of redis calls, and is using both Redis and Redis.Cluster clients to connect to different redis servers. So it might be related to redis cluster. Or newrelic, but I doubt it, processImmediate is something I'd guess would be from the setImmediate call?
This is happening throughout the day
A similar error was among the errors reported in
#1248
I suspect the process.exec might call the callback synchronously in the
same tick in some cases, immediately deleting the autopipeline from
running pipelines?
i.e. my guess is that
.exec
somehow synchronously happens(same tick) and deletes the key from the MapEDIT: This seems to have worked - the service remains running and stable with no issues after upgrading to the ioredis release including this fix (4.27.9) (and
Cannot read property 'Symbol(callbacks)' of undefined
stopped)