Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible sub-optimal flags in cmake #55

Closed
DiamonDinoia opened this issue Jun 11, 2024 · 1 comment
Closed

Possible sub-optimal flags in cmake #55

DiamonDinoia opened this issue Jun 11, 2024 · 1 comment

Comments

@DiamonDinoia
Copy link

The flags used in https://github.com/JuliaPackaging/Yggdrasil/blob/dbe6fe9649dc72119f1bc3f39f8a14e1c0552fd6/F/finufft/build_tarballs.jl#L24 mean:

  1. Use FFTW in the system first
  2. do not enable fftw OpenMP

The package relies on fftw julia package which builds with ptreads. Is there an issue with omp and Julia?

One can do:

  • -DFINUFFT_FFTW_LIBRARIES=DOWNLOAD then finufft downloads, builds and static links fftw.
  • set build type to release (-O3)

preferred gcc version: refer to flatironinstitute/finufft#452

@ludvigak
Copy link
Owner

CMake build type Release made a 5x difference in my tests, new build for that is on the way: JuliaPackaging/Yggdrasil#8956

Did not see much difference in rudimentary tests from changing gcc version and FFTW parallelization. Will not change for now, but may revisit after ongoing round of FINUFFT optimizations have been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants