Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 deprecation message - nullable types #65

Closed
Luc45 opened this issue Dec 12, 2024 · 3 comments · Fixed by #66
Closed

PHP 8.4 deprecation message - nullable types #65

Luc45 opened this issue Dec 12, 2024 · 3 comments · Fixed by #66

Comments

@Luc45
Copy link
Contributor

Luc45 commented Dec 12, 2024

Deprecated: _HumbugBoxdb28ee67b803\lucatume\DI52\Builders\ReinitializableBuilderInterface::reinit(): Implicitly marking parameter $afterBuildMethods as nullable is deprecated, the explicit nullable type must be used instead in phar:///Users/gregbell/.composer/vendor/woocommerce/qit-cli/qit/vendor/lucatume/di52/src/Builders/ReinitializableBuilderInterface.php on line 7

Example line where that deprecation is triggered.

I think it's just a matter of making the parameter nullable, eg:

public function reinit(?array $afterBuildMethods = null, ...$buildArgs);

It seems nullable types was introduced in PHP 7.1, though, which would warrant a minimum version bump.

What do you think?

@lucatume
Copy link
Owner

I will try to update to min 7.1 and add 8.4 tests and see where I land.

@lucatume
Copy link
Owner

I've fixed the issues in version 4.0.0 and bumped the minimum version to 7.1.
Thank you again @Luc45 for reporting the issue.

@Luc45
Copy link
Contributor Author

Luc45 commented Dec 14, 2024

@lucatume Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants