-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename the Session to Connection #3361
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3361 +/- ##
=======================================
Coverage 85.61% 85.61%
=======================================
Files 135 135
Lines 9869 9869
=======================================
Hits 8449 8449
Misses 1043 1043
Partials 377 377
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want any disambiguation from all the conn_* files? With this, we use "conn" for both classes of connections we have. (Maybe rename the conn_* stuff to rawConn, udpConn, sysConn?)
dada2ba
to
6df0216
Compare
6df0216
to
891fe64
Compare
891fe64
to
4b17343
Compare
The term "session" is a remnant from gQUIC days. The QUIC RFC doesn't talk about "sessions", only about connections.
Note that this will be a quite disruptive change for downstream users.