add a CI test that go mod vendor works #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3202 +/- ##
=======================================
Coverage 85.44% 85.44%
=======================================
Files 133 133
Lines 9813 9813
=======================================
Hits 8384 8384
Misses 1055 1055
Partials 374 374 Continue to review full report at Codecov.
|
mvdan
approved these changes
Jun 13, 2021
integrationtests/gomodvendor/go.mod
Outdated
| @@ -0,0 +1,8 @@ | |||
| module github.com/lucas-clemente/quic-go/integrationtets/gomodvendor | |||
There was a problem hiding this comment.
best to not make this module public/importable, to prevent confusion. you could name it module test, as that's a module path prefix reserved specifically for this kind of thing.
There was a problem hiding this comment.
Good point. Didn't know that this was an option :)
marten-seemann
force-pushed
the
gomodvendor
branch
from
0cf7bc7
to
bf8b534
Compare
lucas-clemente
approved these changes
Jun 14, 2021
marten-seemann
force-pushed
the
gomodvendor
branch
from
bf8b534
to
a203702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI will fail, as #3195 is not merged yet.
Makes sure that a failure as reported in #3194 won't happen again in the future.
@mvdan, WDYT?