Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use net.ErrClosed (for Go 1.16) #3163

Merged
merged 1 commit into from
May 4, 2021
Merged

use net.ErrClosed (for Go 1.16) #3163

merged 1 commit into from
May 4, 2021

Conversation

marten-seemann
Copy link
Member

Fixes #2933.

@mvdan, can I ask for your review here?

@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #3163 (b384982) into master (b8f07c7) will decrease coverage by 0.01%.
The diff coverage is 88.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3163      +/-   ##
==========================================
- Coverage   85.43%   85.43%   -0.01%     
==========================================
  Files         132      134       +2     
  Lines        9824     9848      +24     
==========================================
+ Hits         8393     8413      +20     
- Misses       1058     1060       +2     
- Partials      373      375       +2     
Impacted Files Coverage Δ
internal/qerr/errors.go 100.00% <ø> (ø)
internal/qerr/errors_go116.go 83.33% <83.33%> (ø)
internal/qerr/errors_not_go116.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f07c7...b384982. Read the comment docs.

@marten-seemann marten-seemann added this to the v0.21 milestone May 3, 2021
@marten-seemann
Copy link
Member Author

Merging, as we need to cut a release.

@marten-seemann marten-seemann merged commit 8d62ebf into master May 4, 2021
@marten-seemann marten-seemann deleted the err-closed branch May 4, 2021 12:28
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.16: use net.ErrClosed
1 participant