Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to detect version negotiation failures in logging, fix qlogging of those #3092

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

marten-seemann
Copy link
Member

Fixes #3090.

@marten-seemann marten-seemann force-pushed the version-negotiation-failure-logging branch from d7cbbf6 to d468a79 Compare March 15, 2021 05:36
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #3092 (d468a79) into master (3bce408) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3092      +/-   ##
==========================================
+ Coverage   85.72%   85.73%   +0.01%     
==========================================
  Files         131      131              
  Lines        9520     9532      +12     
==========================================
+ Hits         8161     8172      +11     
- Misses        990      991       +1     
  Partials      369      369              
Impacted Files Coverage Δ
logging/close_reason.go 100.00% <100.00%> (ø)
qlog/event.go 97.93% <100.00%> (+0.03%) ⬆️
session.go 76.08% <100.00%> (+0.17%) ⬆️
internal/utils/rand.go 62.50% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bce408...d468a79. Read the comment docs.

@marten-seemann marten-seemann merged commit 5073e30 into master Mar 16, 2021
@marten-seemann marten-seemann deleted the version-negotiation-failure-logging branch March 16, 2021 15:13
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't log version negotiation errors as internal errors
2 participants