improve timeout measurement in the timeout test #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3042 +/- ##
=======================================
Coverage 86.20% 86.20%
=======================================
Files 131 131
Lines 9356 9356
=======================================
Hits 8065 8065
Misses 935 935
Partials 356 356 Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
improve-timeout-test
branch
from
1488495
to
3b1afe4
Compare
marten-seemann
changed the title
When not sending any packets, the idle timeout starts when receiving the HANDSHAKE_DONE frame (on the client side), not when the handshake completes.
marten-seemann
force-pushed
the
improve-timeout-test
branch
from
3b1afe4
to
11c5c54
Compare
lucas-clemente
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not sending any packets, the idle timeout starts when receiving the HANDSHAKE_DONE frame (on the client side), not when the handshake completes.