Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded overflow check when parsing the max_ack_delay #2996

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

marten-seemann
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #2996 (2e5c43b) into master (d1c5297) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2996      +/-   ##
==========================================
+ Coverage   86.12%   86.13%   +0.02%     
==========================================
  Files         135      135              
  Lines        9379     9376       -3     
==========================================
- Hits         8077     8076       -1     
+ Misses        943      942       -1     
+ Partials      359      358       -1     
Impacted Files Coverage Δ
internal/wire/transport_parameters.go 89.30% <100.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c5297...2e5c43b. Read the comment docs.

@marten-seemann marten-seemann merged commit b509337 into master Jan 15, 2021
@marten-seemann marten-seemann deleted the remove-unneeded-overflow-check branch January 15, 2021 09:09
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants