Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow receiving of multiple packets before sending a packet #2984

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

marten-seemann
Copy link
Member

By draining the channel holding received packets, we reduce the number of spurious ACKs we send. We also make sure that sending and receiving packets is balanced, as we allow sending of a large number of packets (if we have cwnd available and the pacing frequency is high enough).

@marten-seemann marten-seemann force-pushed the process-all-received-packets branch from d62f1b2 to 2103bc5 Compare January 6, 2021 03:18
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #2984 (219ced5) into master (4bdccca) will decrease coverage by 0.01%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2984      +/-   ##
==========================================
- Coverage   86.08%   86.07%   -0.01%     
==========================================
  Files         135      135              
  Lines        9397     9410      +13     
==========================================
+ Hits         8089     8099      +10     
- Misses        949      952       +3     
  Partials      359      359              
Impacted Files Coverage Δ
session.go 77.32% <76.47%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bdccca...219ced5. Read the comment docs.

By draining the channel holding received packets, we reduce the number
of spurious ACKs we send. We also make sure that sending and receiving
packets is balanced, as we allow sending of a large number of packets
(if we have cwnd available and the pacing frequency is high enough).
@marten-seemann marten-seemann force-pushed the process-all-received-packets branch from 2103bc5 to 219ced5 Compare January 17, 2021 06:26
@marten-seemann marten-seemann merged commit 3154a3a into master Jan 17, 2021
@marten-seemann marten-seemann deleted the process-all-received-packets branch January 17, 2021 06:40
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants