only run gofumpt on .go files in pre-commit hook

[marten-seemann]

Editing README.md otherwise produces a warning like this:

README.md:1:1: illegal character U+0023 '#'

[codecov]

Codecov Report

Merging #2983 (a6c7671) into master (4c079b9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2983   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files         135      135           
  Lines        9379     9379           
=======================================
  Hits         8077     8077           
  Misses        943      943           
  Partials      359      359           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c079b9...a6c7671. Read the comment docs.

[mvdan]

Huh, I would have thought that *.go would be enough for git. Is three stars any different?

[marten-seemann]

@mvdan You're right. The 3 stars are supposed to do recursive matching, however...

 git diff --cached --name-only -- '*.go'

already matches recursively, whereas

 git diff --cached --name-only -- *.go

does not. By the way,

 git diff --cached --name-only -- ***.go

doesn't match recursively either, but

git diff --cached --name-only -- **/*.go

does.

Please remember this for the next time you use git to filter through files ;)

[mvdan]

Those are different :) I always use '*.go', since that literally just passes that string to git, meaning "any indexed file which has a go extension". Without the quoting, then the shell just tries to expand to the Go files in the current directory, which is entirely different.