Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the HTTP/3 Datagram negotiation #2951

Merged
merged 4 commits into from
Dec 23, 2020

Conversation

marten-seemann
Copy link
Member

Depends on #2949.

According to https://www.ietf.org/archive/id/draft-schinazi-masque-h3-datagram-02.html.

This PR only adds support for writing and parsing of the datagram option in the HTTP/3 SETTINGS frame, as well as adds the check that datagram support was enabled on the QUIC layer if both client and server negotiated it on the H3 layer.
It is not yet possible to actually send and receive H3 datagrams. That will be added in a subsequent PR.

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #2951 (b753005) into master (f68dfd5) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2951      +/-   ##
==========================================
+ Coverage   86.12%   86.18%   +0.06%     
==========================================
  Files         134      134              
  Lines        9326     9364      +38     
==========================================
+ Hits         8032     8070      +38     
  Misses        935      935              
  Partials      359      359              
Impacted Files Coverage Δ
http3/client.go 88.68% <100.00%> (+0.52%) ⬆️
http3/frames.go 80.00% <100.00%> (+5.40%) ⬆️
http3/roundtrip.go 93.33% <100.00%> (+0.11%) ⬆️
http3/server.go 68.70% <100.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f68dfd5...b753005. Read the comment docs.

@marten-seemann marten-seemann merged commit 4ad144c into master Dec 23, 2020
@marten-seemann marten-seemann deleted the h3-datagram-negotiation branch December 23, 2020 08:19
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants