Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logging of bytes_in_flight when receiving an ACK #2937

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

marten-seemann
Copy link
Member

The tracing call needs to be issued after subtracting acknowledged and lost packets from the bytes_in_flight.

The tracing call needs to be issued after subtracting acknowledged and
lost packets from the bytes_in_flight.
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #2937 (d3abf0e) into master (4867389) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2937   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files         132      132           
  Lines        9160     9160           
=======================================
  Hits         7894     7894           
  Misses        914      914           
  Partials      352      352           
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_handler.go 78.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4867389...d3abf0e. Read the comment docs.

@marten-seemann marten-seemann merged commit c20a924 into master Dec 16, 2020
@marten-seemann marten-seemann deleted the fix-bytes-in-flight-tracing-after-ack branch December 17, 2020 04:23
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants