Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send STREAMS_BLOCKED frame when MAX_STREAMS frame allows too few streams #2828

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

marten-seemann
Copy link
Member

Depends on #2827. Fixes #2826.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #2828 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2828   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files         134      134           
  Lines        9063     9065    +2     
=======================================
+ Hits         7776     7778    +2     
  Misses        946      946           
  Partials      341      341           
Impacted Files Coverage Δ
streams_map_outgoing_generic.go 95.15% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff639a4...5c5e102. Read the comment docs.

@marten-seemann marten-seemann force-pushed the send-streams-blocked-on-max-streams branch from 9f0e355 to 80428ad Compare October 26, 2020 02:55
@marten-seemann marten-seemann force-pushed the send-streams-blocked-on-max-streams branch from 80428ad to 5c5e102 Compare October 30, 2020 08:28
@marten-seemann marten-seemann merged commit b034f1a into master Oct 30, 2020
@marten-seemann marten-seemann deleted the send-streams-blocked-on-max-streams branch October 30, 2020 12:17
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

send STREAMS_BLOCKED frames if MAX_STREAMS didn't grant enough credit
2 participants