Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save dummy packets in the packet history when skipping packet numbers #2753

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

marten-seemann
Copy link
Member

Depends on #2752 and #2750.

By saving a dummy packet in the packet history we can get rid of the separate tracking of skipped packet numbers.

@lucas-clemente Only the last 2 commits are new in this PR.

@marten-seemann marten-seemann changed the title save dummy packet in the packet history when skipping packets save dummy packets in the packet history when skipping packet numbers Sep 7, 2020
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2753 into master will increase coverage by 0.01%.
The diff coverage is 86.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
+ Coverage   86.71%   86.72%   +0.01%     
==========================================
  Files         128      128              
  Lines       10033    10039       +6     
==========================================
+ Hits         8700     8706       +6     
  Misses       1006     1006              
  Partials      327      327              
Impacted Files Coverage Δ
internal/ackhandler/packet_number_generator.go 100.00% <ø> (ø)
internal/ackhandler/sent_packet_handler.go 74.73% <75.00%> (+0.48%) ⬆️
internal/ackhandler/sent_packet_history.go 96.61% <90.48%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f2610...12c9427. Read the comment docs.

@marten-seemann marten-seemann merged commit 9605edd into master Sep 11, 2020
@marten-seemann marten-seemann deleted the simplify-packet-number-skipping branch September 11, 2020 05:10
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants