Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the SupportedVersions slice out of the wire.Header #2664

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

marten-seemann
Copy link
Member

There's no need to have this slice in the wire.Header. We can reduce the memory size of this struct by treating the supported version as "payload" of a Version Negotiation packet, instead of as part of the header. Not only is this more efficient, it's also more consistent with the QUIC draft.

@marten-seemann marten-seemann force-pushed the move-versions-out-of-the-header branch from ee342be to 993d71f Compare July 9, 2020 05:05
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #2664 into master will decrease coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2664      +/-   ##
==========================================
- Coverage   86.44%   86.42%   -0.02%     
==========================================
  Files         122      122              
  Lines        9763     9766       +3     
==========================================
+ Hits         8439     8440       +1     
- Misses        989      990       +1     
- Partials      335      336       +1     
Impacted Files Coverage Δ
internal/wire/version_negotiation.go 86.67% <73.33%> (-13.33%) ⬇️
internal/wire/header.go 92.19% <100.00%> (+0.76%) ⬆️
qlog/qlog.go 95.37% <100.00%> (ø)
session.go 76.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953f347...993d71f. Read the comment docs.

@marten-seemann marten-seemann merged commit f16d474 into master Jul 10, 2020
@marten-seemann marten-seemann deleted the move-versions-out-of-the-header branch July 10, 2020 11:25
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants