From 026b4757d4d7308e1f91f0f6d863bec6aa072585 Mon Sep 17 00:00:00 2001 From: Luca Di Grazia Date: Sun, 4 Sep 2022 19:16:08 +0200 Subject: [PATCH] Enable the flag incompatible_disallow_hashing_frozen_mutables Fixes https://github.com/bazelbuild/bazel/issues/7800 RELNOTES: The flag incompatible_disallow_hashing_frozen_mutables is enabled (https://github.com/bazelbuild/bazel/issues/7800) PiperOrigin-RevId: 264659899 --- .../lib/packages/StarlarkSemanticsOptions.java | 2 +- .../build/lib/syntax/StarlarkSemantics.java | 2 +- .../lib/analysis/ConfigurableAttributesTest.java | 16 ---------------- 3 files changed, 2 insertions(+), 18 deletions(-) diff --git a/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java index cc547c202a9..72ca374c696 100644 --- a/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java +++ b/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java @@ -499,7 +499,7 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl @Option( name = "incompatible_no_target_output_group", - defaultValue = "true", + defaultValue = "false", documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS, effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS}, metadataTags = { diff --git a/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java index d89b48d55b0..7ad0bb86a80 100644 --- a/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java +++ b/dataset/GitHub_Java/bazelbuild.bazel/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java @@ -271,7 +271,7 @@ public static Builder builderWithDefaults() { .incompatibleNoOutputAttrDefault(true) .incompatibleNoRuleOutputsParam(false) .incompatibleNoSupportToolsInActionInputs(true) - .incompatibleNoTargetOutputGroup(true) + .incompatibleNoTargetOutputGroup(false) .incompatibleNoTransitiveLoads(true) .incompatibleObjcFrameworkCleanup(true) .incompatibleRemapMainRepo(false) diff --git a/dataset/GitHub_Java/bazelbuild.bazel/src/test/java/com/google/devtools/build/lib/analysis/ConfigurableAttributesTest.java b/dataset/GitHub_Java/bazelbuild.bazel/src/test/java/com/google/devtools/build/lib/analysis/ConfigurableAttributesTest.java index ad3f8f9bb5f..e2fc41b18d5 100644 --- a/dataset/GitHub_Java/bazelbuild.bazel/src/test/java/com/google/devtools/build/lib/analysis/ConfigurableAttributesTest.java +++ b/dataset/GitHub_Java/bazelbuild.bazel/src/test/java/com/google/devtools/build/lib/analysis/ConfigurableAttributesTest.java @@ -494,22 +494,6 @@ public void configKeyNonexistentTarget() throws Exception { assertContainsEvent("//foo:fake is not a valid configuration key for //foo:g"); } - @Test - public void configKeyNonexistentTarget_otherPackage() throws Exception { - reporter.removeHandler(failFastHandler); // Expect errors. - scratch.file("bar/BUILD"); - scratch.file( - "foo/BUILD", - "genrule(", - " name = 'g',", - " outs = ['g.out'],", - " cmd = select({'//bar:fake': ''})", - ")"); - assertThat(getConfiguredTarget("//foo:g")).isNull(); - assertContainsEvent( - "While resolving configuation keys for //foo:g: no such target '//bar:fake'"); - } - /** * Tests config keys with multiple requirements. */