Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering parameter and function created #15

Closed
wants to merge 3 commits into from

Conversation

DanAmador
Copy link

@DanAmador DanAmador commented Oct 8, 2018

Created an order parameter which orders the bookmark bar by title.

resolves #6

@@ -16,6 +17,7 @@ defmodule Bookmarker.CLI do
h: :help,
f: :file,
t: :title,
or: :order,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to leave a letter only version '-o' instead of '-or'.

Copy link
Author

@DanAmador DanAmador Oct 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose to use or as the char "o" was already being used for the "output" key in line 24.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. My bad.

Maybe we could rename the flag to "--sort", "-s".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'll fix that in a sec 👍

@lubien lubien mentioned this pull request Oct 8, 2018
4 tasks
@lubien
Copy link
Owner

lubien commented Oct 8, 2018

I just merged another PR you might need to rebase your repo.

@DanAmador DanAmador changed the title Formatted a bit and added ordering Ordering parameter and function created Oct 9, 2018
@@ -81,7 +81,7 @@ defmodule Bookmarker.CLI do
Default: Google Chrome Bookmarks
-d, --description Set a description for the rendered markdown.
Default: Generated by Bookmarker
-or, --order Set if the list is ordered
-s, --s Set if the list is ordered
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the full word "--sort".

image

Also don't forget to indent

-p, --path Restrict to folder. You may set this one time only.
-o, --output Save rendered markdown to a file.
Default: none (output to stdin)
-f, --file Set where your chrome bookmarks file is.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but you broke the original indentation

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the previous format.

@miread miread mentioned this pull request Jun 20, 2019
@lubien lubien closed this in #21 Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order items
2 participants