-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ordering parameter and function created #15
Conversation
lib/bookmarker/cli.ex
Outdated
@@ -16,6 +17,7 @@ defmodule Bookmarker.CLI do | |||
h: :help, | |||
f: :file, | |||
t: :title, | |||
or: :order, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be best to leave a letter only version '-o' instead of '-or'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to use or as the char "o" was already being used for the "output" key in line 24.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. My bad.
Maybe we could rename the flag to "--sort", "-s".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I'll fix that in a sec 👍
I just merged another PR you might need to rebase your repo. |
lib/bookmarker/cli.ex
Outdated
@@ -81,7 +81,7 @@ defmodule Bookmarker.CLI do | |||
Default: Google Chrome Bookmarks | |||
-d, --description Set a description for the rendered markdown. | |||
Default: Generated by Bookmarker | |||
-or, --order Set if the list is ordered | |||
-s, --s Set if the list is ordered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-p, --path Restrict to folder. You may set this one time only. | ||
-o, --output Save rendered markdown to a file. | ||
Default: none (output to stdin) | ||
-f, --file Set where your chrome bookmarks file is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but you broke the original indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the previous format.
Created an order parameter which orders the bookmark bar by title.
resolves #6