Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add fill done drawable #6

Closed
wants to merge 2 commits into from

Conversation

Mrey3000
Copy link

No description provided.

@Mrey3000
Copy link
Author

Add step done drawble
image

@loukwn
Copy link
Owner

loukwn commented Jan 16, 2024

Hello @Mrey3000 sorry I just noticed your PR. Can you tell me your use case and why this change is needed? Can you not achieve what you want with the current implementation?

Thanks a lot for the PR!

@loukwn
Copy link
Owner

loukwn commented Jan 16, 2024

Actually is it to provide a different kind of drawable for the thumbs that are already completed? As in your screenshot the one in the right was visited first so it is "done" , the one in the center is the one being visited now so is in progress and it has a different drawable and the one on the left is not visited at all?

If so, this library assumes that all "visited" thumbs are filled and the rest are unfilled. I do not think a solution to add an "done" kind of thumb type is appropriate to me.

What I could do is add a way to provide custom drawables for filled thumbs by either providing a list or something similar.

I will put some thought in to it!

@loukwn loukwn mentioned this pull request Jan 28, 2024
@loukwn
Copy link
Owner

loukwn commented Jan 28, 2024

@Mrey3000 Sorry for taking a while on this. I started doing a general refactor but that turned out to be a big job for now (probably will plan it for a 2.0.0 release). For now I just added an activeThumb property both in the Compose and the View versions that represents the last filled stage/thumb so you can customize it properly and it also changes nicely during animations too. Will ship with the 1.2.0 release quite soon!

I will close this PR as it is unneeded, but thanks a lot for taking the time to open this! Do let me know if you need anything else feature wise and I will try to accomodate!

@loukwn loukwn closed this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants