Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UP alerts configurable #1562

Closed
1 task done
traskat opened this issue Apr 25, 2022 · 5 comments
Closed
1 task done

UP alerts configurable #1562

traskat opened this issue Apr 25, 2022 · 5 comments
Labels
feature-request Request for new features to be added

Comments

@traskat
Copy link

traskat commented Apr 25, 2022

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

UI Feature, Other

🔖 Feature description

i think it would be great to have checkbox which gives the option to enable or disable UP alerts.
As an example: i would like to have up alerts in my alerts channel in some chat based system, but i don't to have up alerts on email notification.

✔️ Solution

as said above. a simple checkbox to enable or disable up alerts for specific notification

❓ Alternatives

NA

📝 Additional Context

NA

@traskat traskat added the feature-request Request for new features to be added label Apr 25, 2022
@openstep
Copy link

I also support this idea.

@openstep
Copy link

As a workaround I modified server/notification-providers/smtp.js by adding the code right below this code block

// Lets start with default subject and empty string for custom one
        let subject = msg;

Adding this code block after the above one

        // Do not send email if msg contains "✅ Up"
	    if (subject.includes("✅ Up")){
	        return;
            }    

This achieves your requirement without the clickable button. All other notifications remain the same.

@traskat
Copy link
Author

traskat commented Apr 26, 2022

Thanks. but i was thinking about a pull request.
and wanted to add it more or less here to the defaults.

since it should affect the choosen notification provider.
But i will check again if there is a better way. i also need to check on the server side. how it can be implemented.

@CommanderStorm
Copy link
Collaborator

@traskat
I think this is a duplicate of #1233 and partially #1137 / #3585
If you agree, could you please close this Issue, as duplicates only create immortal zombies and are really hard to issue-manage?
If not, what makes this issue unique enough to require an additional issue? (Could this be integrated into the issue linked above?) ^^

@CommanderStorm
Copy link
Collaborator

@traskat
We are consolidating duplicate issues a bit to make issue management easier.
I think, we should track this issue in ##1233 and partially #1137 / #3585 as there is no functional difference (maybe just small naming differences, but nothing that would require a different issue imo)
⇒ I am going to close this as a duplicate.

@CommanderStorm CommanderStorm closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features to be added
Projects
None yet
Development

No branches or pull requests

3 participants