From 38661a6aa50204e7204182bf7eeec45e2a87f14b Mon Sep 17 00:00:00 2001 From: Jafar Al-Gharaibeh Date: Tue, 15 Oct 2024 11:11:03 -0500 Subject: [PATCH] vtysh: fix SA warning, no need to call getenv() twice Signed-off-by: Jafar Al-Gharaibeh --- vtysh/vtysh_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/vtysh/vtysh_main.c b/vtysh/vtysh_main.c index 64198132cc64..297d87ec419d 100644 --- a/vtysh/vtysh_main.c +++ b/vtysh/vtysh_main.c @@ -350,6 +350,7 @@ int main(int argc, char **argv, char **env) char pathspace[MAXPATHLEN] = ""; const char *histfile = NULL; const char *histfile_env = getenv("VTYSH_HISTFILE"); + const char *logpath = getenv("VTYSH_LOG"); /* SUID: drop down to calling user & go back up when needed */ elevuid = geteuid(); @@ -643,9 +644,7 @@ int main(int argc, char **argv, char **env) } } - if (getenv("VTYSH_LOG")) { - const char *logpath = getenv("VTYSH_LOG"); - + if (logpath != NULL) { logfile = fopen(logpath, "a"); if (!logfile) { fprintf(stderr, "Failed to open logfile (%s): %s\n",