Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem hash difference #165

Closed
ghost opened this issue Aug 3, 2017 · 11 comments
Closed

Gem hash difference #165

ghost opened this issue Aug 3, 2017 · 11 comments

Comments

@ghost
Copy link

ghost commented Aug 3, 2017

I'm seeing a similar issue to rubygems/bundler#5332

Basically if I run gem fetch faraday_middleware -v 0.12.1 then shasum -a256 faraday_middleware-0.12.1.gem the hash I see (021dc9fd7e7b6de1bc394637c7b8214a1f8b2d1407867e5239c90b5405a31ff3) is different than the one on rubygems.org (06764c0b5e7f10a5efeae501da2c825f0e479969c8ca9b585583fd6546ba63df).

Republishing seemed to help last time. Can we try again?

As a side note, seems a little odd that it happens to this gem twice but is a rare thing?

@beloso
Copy link

beloso commented Aug 3, 2017

I am having the same problem:

(The expected SHA256 checksum was "06764c0b5e7f10a5efeae501da2c825f0e479969c8ca9b585583fd6546ba63df", but
the checksum for the downloaded gem was "021dc9fd7e7b6de1bc394637c7b8214a1f8b2d1407867e5239c90b5405a31ff3".)

@wojtha
Copy link

wojtha commented Aug 3, 2017

Ran into this as well, it seems to be caused by Travis CI publishing process as @sonalkr132 wrote:

I believe we know why this is happening. You are using Travis to push gems. Travis ends pushing the gem from all the jobs. One of them pass and rest fail. Because of the race condition in Api::V1::RubygemsController#create, we end up with incorrect checksums.

@adellibovi
Copy link

Exactly same problem here too
(More info: The expected SHA256 checksum was "06764c0b5e7f10a5efeae501da2c825f0e479969c8ca9b585583fd6546ba63df", but the checksum for the downloaded gem was "021dc9fd7e7b6de1bc394637c7b8214a1f8b2d1407867e5239c90b5405a31ff3".)

@zero3nna
Copy link

zero3nna commented Aug 3, 2017

Same problem for me if our Jenkins tries to bundle update

@iMacTia
Copy link
Member

iMacTia commented Aug 3, 2017

I'm sorry guys this happened again, I thought this was fixed limiting the rubygems release to only some jobs. Clearly the fix is not working as expected, but it worked just fine for v0.12.0.
I'll try to get this fixed ASAP

@iMacTia
Copy link
Member

iMacTia commented Aug 3, 2017

this is the condition I'm referring to, it should publish on Rubygems ONLY for the "2.4.0 / Gemfile" combination.
I'll keep looking around for a reason but any suggestion is really welcome

@iMacTia
Copy link
Member

iMacTia commented Aug 3, 2017

I'll try to apply the fix from this rubygems/rubygems.org#1551 (comment) and re-release

@iMacTia
Copy link
Member

iMacTia commented Aug 3, 2017

v0.12.2 on its way, finger crossed 🤞

@adellibovi
Copy link

Thanks a lot @iMacTia and absolutely no need to be sorry about this :)

@iMacTia
Copy link
Member

iMacTia commented Aug 3, 2017

Thanks @adellibovi, and just to be extra safe I'm running tests for ruby 2.4.0 only against the base Gemfile. I don't want to see race conditions anymore!

@iMacTia
Copy link
Member

iMacTia commented Aug 3, 2017

faraday_middleware 0.12.2 released

A quick gem install faraday_middleware successfully installed v0.12.2 so hopefully this is now fixed 👍

@iMacTia iMacTia closed this as completed Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants