Make the panel indicator a toggle-button

[amivaleo]

Hi!

This is just a suggestion rather than a bug: the panel indicator might work as a toggle button instead of opening a popover menu. Hence, clicking on the button would either enable or disable the dark theme, according to the previous state of the button. At each of the two states of the button, the indicator could change icon.

Just a suggestion. It would reduce the number of clicks and the number of items added by your extension in the top panel.

If help is needed, I think I can provide an example of such toggle-indicator. I already have a simple extension that works like that, for something completely different. The fact is I am a donkey at coding extensions, so I can give much help apart from providing that example.

💪

[lossurdo]

Nice to hear from you, Jimmy!
Thanks for your suggestion.
I need to improve my extensions development skills and add that feature.
Keep on touch.

[amivaleo]

Uhm... I can see there's a very similar extension, indeed: https://extensions.gnome.org/extension/2302/daynight/

It uses a toggle-button.
So... Just... Like... Copy&paste? 😅

[lossurdo]

The extension you recommended is exactly what I wanted to do. It is better than mine 😄!
It would be better for me to fork it and make it better, isn't it?

[amivaleo]

Apologies, Only now I understand I was rude in my previous comment... :(

You might consider changing the goal of your extension just a bit, maybe. 🤔

Take a look at this, for example: https://github.com/amivaleo/JustAPerfectTheme