-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use numbers option during json decoding #191
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Hi i m facing the the invalid TransactionId problem currently on my Alfen box do you think this patch will solve the Alfen ID issue? |
No. It does not solve the issue. It is an problem within the Alfen firmware up to the most current version 6.4.0. I have open tickets with Alfen for more than one year now. The problem is that they set MaxInt as invalid value and I assume that this happens if you use SetChargeProfile without a TransactionId (although the spec allows this and it makes sense in many use cases, Alfen then "forgets" current transactionId leading to the problem described. Is this also your case, maybe you can help with contacting Alfen to solve this? The only thing you might do is to catch it with an invalid message callback, see here #188 Info on InvalidMessageHook can be found here: #215 |
Hi, i gues iita the same problem.
is it not possible to fix it somehow on the server side by setting the tanactionId for the profile. |
@olga2323 @ALL: please excuse OT post. Working on https://github.com/evcc-io/evcc we're faced with varying compatibility issues like the one mentioned above. Would you be interested in creating a collaboration area for cross-project exchange on vendor issues, does and don'ts? Maybe Github or anything else. Please excuse the OT post- thank you! |
Forces the
UseNumber
option on the JSON decoder while parsing a message. This prevents intermediate conversion to float64 values, which may cut off values on very high numbers and cause rounding errors.This will likely introduce some performance decrease, since the
json.Decoder
is more memory-intensive. Optimization will be analyzed later on.Solves #188