Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info to readme about ORLY_BASE_HOST for SSO #304

Closed
fredlarochelle opened this issue Jan 12, 2022 · 2 comments
Closed

Add info to readme about ORLY_BASE_HOST for SSO #304

fredlarochelle opened this issue Jan 12, 2022 · 2 comments
Labels

Comments

@fredlarochelle
Copy link

As said in the title, info should be added to the readme about a possible reason why SSO might not be working for some folks. In my case, the URL was different than "oreilly.com". I simply changed the value of ORLY_BASE_HOST (line 24 of safaribooks.py) to the correct URL and it started working.

Should I make a pull request for such a simple change to the readme?

@lorenzodifuccia
Copy link
Owner

I think that for SSO is better what said until now: "use authenticated cookie".
See: README, #150 (comment)

If you don't agree, please reopen this issue!

@esmail
Copy link

esmail commented Jun 21, 2024

I think what OP is saying is that in some cases you're not logging into "oreilly.com" and it would be good to have documentation on how to modify things accordingly.

In my case (accessing O'Reilly through my public library), I had to set all three of ORLY_BASE_URL, SAFARI_BASE_URL, and API_ORIGIN_URL to "https://learning-oreilly-com.opl.idm.oclc.org" (at which point the *_HOST constants weren't needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants