Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use operation hooks instead of deprecated model hooks #1097

Open
bajtos opened this issue Sep 19, 2016 · 0 comments
Open

Use operation hooks instead of deprecated model hooks #1097

bajtos opened this issue Sep 19, 2016 · 0 comments
Labels

Comments

@bajtos
Copy link
Member

bajtos commented Sep 19, 2016

See the discussion in #824. We were not able to remove deprecated model hooks because embedded relations are still relying on them.

There is a feature for inst.triggerParent in embedsMany that needs more consideration and possibly a rewrite for embedded relations to continue work. It is for updating the parent model if any changes are made to the relation. This part needs a redesign and rewrite to consider the different cases and to make it all consistent.

We should rewrite inst.triggerParent to not depend on deprecated hooks, for example using the approach outlined in d0cc791

cc @jannyHou @Amir-61 @superkhau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants