fix: No results message not showing #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesudeep
reviewed
Oct 5, 2023
| // need to supply the container with something new if we fail early and | ||
| // don't make it to the inteded render function. | ||
| // https://looker.atlassian.net/browse/DX-5779 | ||
| if (data.length < 1) { |
There was a problem hiding this comment.
What's the difference between data.length === 0 and data.length < 1?
There was a problem hiding this comment.
Not much difference, I took some code from other vis that had a similar issue, so that stayed. But no difference at all in this case.
| this.addError({ | ||
| title: "No Results", | ||
| }); | ||
| done(); |
There was a problem hiding this comment.
What does "done()?" do. It appears to have been removed from the above code.
There was a problem hiding this comment.
Calling done() after adding the error is what caused the bug. Visualization would return but it would never add the error message so it wouldn't update or show.
mendozamedina
pushed a commit
that referenced
this pull request
Dec 5, 2024
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2024-12-05) ### Features * Adds CI implementation ([#16](#16)) ([3e75a7b](3e75a7b)) ### Bug Fixes * No results message not showing ([#5](#5)) ([dba5e34](dba5e34)) * upgrades styled-components to remove @babel/traverse vulnerability ([#21](#21)) ([bc767cf](bc767cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.