Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a field with a Schema is optional: true, then validation fails #495

Closed
scharf opened this issue Mar 27, 2024 · 2 comments
Closed

When a field with a Schema is optional: true, then validation fails #495

scharf opened this issue Mar 27, 2024 · 2 comments

Comments

@scharf
Copy link

scharf commented Mar 27, 2024

Given this code:

import SimpleSchema from 'simpl-schema';

const SubSchema = new SimpleSchema({
    field: {
        type: String,
    },
});

const MainSchema = new SimpleSchema({
    parent: {
        type: SubSchema,
        optional: true,
    },
});

// Validate an empty object
MainSchema.validate({});

I get the following error:

{
  errorType: 'ClientError',
  error: 'validation-error',
  details: [
    {
      name: 'parent.field',
      type: 'required',
      value: undefined,
      message: 'Field is required'
    }
  ]
}

I would not expect to see any errors because parent is optional.

Copy link

Thank you for submitting an issue!

If this is a bug report, please be sure to include, at minimum, example code showing a small schema and any necessary calls with all their arguments, which will reproduce the issue. Even better, you can link to a saved online code editor example, where anyone can immediately run the code and see the issue.

If you are requesting a feature, include a code example of how you imagine it working if it were implemented.

If you need to edit your issue description, click the [...] and choose Edit.

Be patient. This is a free and freely licensed package that I maintain in my spare time. You may get a response in a day, but it could also take a month. If you benefit from this package and would like to see more of my time devoted to it, you can help by sponsoring.

@scharf
Copy link
Author

scharf commented Mar 27, 2024

duplicate of #475

@scharf scharf closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant