Skip to content

Commit 96344b2

Browse files
authored
fix: Hao xu request source timestamp_field (feast-dev#4495)
* not sure why fix linting Signed-off-by: cmuhao <sduxuhao@gmail.com> * not sure why fix linting Signed-off-by: cmuhao <sduxuhao@gmail.com> --------- Signed-off-by: cmuhao <sduxuhao@gmail.com>
1 parent 4a6b663 commit 96344b2

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

README.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ The list below contains the functionality that contributors are planning to deve
187187
* [x] On-demand Transformations (Beta release. See [RFC](https://docs.google.com/document/d/1lgfIw0Drc65LpaxbUu49RCeJgMew547meSJttnUqz7c/edit#))
188188
* [x] Streaming Transformations (Alpha release. See [RFC](https://docs.google.com/document/d/1UzEyETHUaGpn0ap4G82DHluiCj7zEbrQLkJJkKSv4e8/edit))
189189
* [ ] Batch transformation (In progress. See [RFC](https://docs.google.com/document/d/1964OkzuBljifDvkV-0fakp2uaijnVzdwWNGdz7Vz50A/edit))
190+
* [ ] Persistent On-demand Transformations (Beta release. See [GitHub Issue](https://github.com/feast-dev/feast/issues/4376))
190191
* **Streaming**
191192
* [x] [Custom streaming ingestion job support](https://docs.feast.dev/how-to-guides/customizing-feast/creating-a-custom-provider)
192193
* [x] [Push based streaming data ingestion to online store](https://docs.feast.dev/reference/data-sources/push)
@@ -208,6 +209,9 @@ The list below contains the functionality that contributors are planning to deve
208209
* [x] Amundsen integration (see [Feast extractor](https://github.com/amundsen-io/amundsen/blob/main/databuilder/databuilder/extractor/feast_extractor.py))
209210
* [x] DataHub integration (see [DataHub Feast docs](https://datahubproject.io/docs/generated/ingestion/sources/feast/))
210211
* [x] Feast Web UI (Beta release. See [docs](https://docs.feast.dev/reference/alpha-web-ui))
212+
* [ ] Feast Lineage Explorer
213+
* **Natural Language Processing**
214+
* [x] Vector Search (Alpha release. See [RFC](https://docs.google.com/document/d/18IWzLEA9i2lDWnbfbwXnMCg3StlqaLVI-uRpQjr_Vos/edit#heading=h.9gaqqtox9jg6))
211215

212216

213217
## 🎓 Important Resources
@@ -230,4 +234,4 @@ Thanks goes to these incredible people:
230234

231235
<a href="https://github.com/feast-dev/feast/graphs/contributors">
232236
<img src="https://contrib.rocks/image?repo=feast-dev/feast" />
233-
</a>
237+
</a>

sdk/python/feast/data_source.py

+10-1
Original file line numberDiff line numberDiff line change
@@ -524,12 +524,19 @@ def __init__(
524524
*,
525525
name: str,
526526
schema: List[Field],
527+
timestamp_field: Optional[str] = None,
527528
description: Optional[str] = "",
528529
tags: Optional[Dict[str, str]] = None,
529530
owner: Optional[str] = "",
530531
):
531532
"""Creates a RequestSource object."""
532-
super().__init__(name=name, description=description, tags=tags, owner=owner)
533+
super().__init__(
534+
name=name,
535+
timestamp_field=timestamp_field,
536+
description=description,
537+
tags=tags,
538+
owner=owner,
539+
)
533540
self.schema = schema
534541

535542
def validate(self, config: RepoConfig):
@@ -570,6 +577,7 @@ def from_proto(data_source: DataSourceProto):
570577
return RequestSource(
571578
name=data_source.name,
572579
schema=list_schema,
580+
timestamp_field=data_source.timestamp_field,
573581
description=data_source.description,
574582
tags=dict(data_source.tags),
575583
owner=data_source.owner,
@@ -593,6 +601,7 @@ def to_proto(self) -> DataSourceProto:
593601
tags=self.tags,
594602
owner=self.owner,
595603
)
604+
data_source_proto.timestamp_field = self.timestamp_field
596605
data_source_proto.request_data_options.schema.extend(schema_pb)
597606

598607
return data_source_proto

0 commit comments

Comments
 (0)