Skip to content

Commit 4293608

Browse files
authored
fix: Update react-router-dom to 6.3.0 and restrict its version in Feast UI (feast-dev#4556)
As noted in feast-dev#3794, Feast UI is not compatible with latest react-router-dom versions, more precisely from 6.4.0 onwards. Limit react-router-dom version to a compatible range to avoid the runtime errors mentioned in the issue when installing peer dependencies without specifying exact versions. After setting the restricted versions, `yarn install` updated `react-router-dom` to the latest compatible version 6.3.0. It should be a minor upgrade (https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v630), and I didn't notice anything not working in the UI after it. Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
1 parent f308572 commit 4293608

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

ui/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"react": "^17.0.2",
2121
"react-dom": "^17.0.2",
2222
"react-query": "^3.34.12",
23-
"react-router-dom": "6",
23+
"react-router-dom": "<6.4.0",
2424
"react-scripts": "^5.0.0",
2525
"use-query-params": "^1.2.3",
2626
"zod": "^3.11.6"
@@ -37,7 +37,7 @@
3737
"query-string": "^7.1.1",
3838
"react-code-blocks": "^0.0.9-0",
3939
"react-query": "^3.34.12",
40-
"react-router-dom": "6",
40+
"react-router-dom": "<6.4.0",
4141
"react-scripts": "^5.0.0",
4242
"tslib": "^2.3.1",
4343
"use-query-params": "^1.2.3",

ui/yarn.lock

+9-9
Original file line numberDiff line numberDiff line change
@@ -9345,18 +9345,18 @@ react-remove-scroll@^2.5.2:
93459345
use-callback-ref "^1.3.0"
93469346
use-sidecar "^1.1.2"
93479347

9348-
react-router-dom@6:
9349-
version "6.2.1"
9350-
resolved "https://registry.yarnpkg.com/react-router-dom/-/react-router-dom-6.2.1.tgz#32ec81829152fbb8a7b045bf593a22eadf019bec"
9351-
integrity sha512-I6Zax+/TH/cZMDpj3/4Fl2eaNdcvoxxHoH1tYOREsQ22OKDYofGebrNm6CTPUcvLvZm63NL/vzCYdjf9CUhqmA==
9348+
react-router-dom@<6.4.0:
9349+
version "6.3.0"
9350+
resolved "https://registry.yarnpkg.com/react-router-dom/-/react-router-dom-6.3.0.tgz#a0216da813454e521905b5fa55e0e5176123f43d"
9351+
integrity sha512-uaJj7LKytRxZNQV8+RbzJWnJ8K2nPsOOEuX7aQstlMZKQT0164C+X2w6bnkqU3sjtLvpd5ojrezAyfZ1+0sStw==
93529352
dependencies:
93539353
history "^5.2.0"
9354-
react-router "6.2.1"
9354+
react-router "6.3.0"
93559355

9356-
react-router@6.2.1:
9357-
version "6.2.1"
9358-
resolved "https://registry.yarnpkg.com/react-router/-/react-router-6.2.1.tgz#be2a97a6006ce1d9123c28934e604faef51448a3"
9359-
integrity sha512-2fG0udBtxou9lXtK97eJeET2ki5//UWfQSl1rlJ7quwe6jrktK9FCCc8dQb5QY6jAv3jua8bBQRhhDOM/kVRsg==
9356+
react-router@6.3.0:
9357+
version "6.3.0"
9358+
resolved "https://registry.yarnpkg.com/react-router/-/react-router-6.3.0.tgz#3970cc64b4cb4eae0c1ea5203a80334fdd175557"
9359+
integrity sha512-7Wh1DzVQ+tlFjkeo+ujvjSqSJmkt1+8JO+T5xklPlgrh70y7ogx75ODRW0ThWhY7S+6yEDks8TYrtQe/aoboBQ==
93609360
dependencies:
93619361
history "^5.2.0"
93629362

0 commit comments

Comments
 (0)