Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox closes on press of buttons O/X/C or numpad 3 button #621

Closed
veerendratasol opened this issue Feb 23, 2018 · 3 comments
Closed

Lightbox closes on press of buttons O/X/C or numpad 3 button #621

veerendratasol opened this issue Feb 23, 2018 · 3 comments

Comments

@veerendratasol
Copy link

What version of Lightbox2 you are using?
I am using version 2.9.0
Which browsers and operating systems have you seen the issue on?
All browser and operating system

What are the steps to reproduce the bug?
if you click on the official example page also
http://lokeshdhakar.com/projects/lightbox2/
Click on any example image the lightbox will be opened but if you press any of the below mentioned keys the lightbox will be closed

O / X / C or numpad 3 button

Do you have link to a live site where the bug is visible? or can you post relevant HTML, CSS, and Javascript?

The issue is visible in the lightbox demo too
http://lokeshdhakar.com/projects/lightbox2/

@lokesh
Copy link
Owner

lokesh commented Apr 20, 2019

Closing out old issues.

Thanks for reporting. These alphanumeric keys are alternatives to Esc to close the Lightbox:

  1. The x resembles the X close icon.
  2. The c is for 'Close'.
  3. And the o... well, I can't remember.

These alternatives to Esc were added a very long time ago. They aren't intuitive, they are not discoverable, and if anything, they are more likely to conflict the other keypress event handlers that a dev has tried to add. I'm going to strip them out. Thanks again.

@lokesh
Copy link
Owner

lokesh commented Apr 20, 2019

#649

@lokesh lokesh mentioned this issue Apr 22, 2019
@lokesh
Copy link
Owner

lokesh commented Apr 22, 2019

@lokesh lokesh closed this as completed Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants