feat(core): core functions to interact with OIDC APIs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyijun
requested review from
wangsijie,
IceHe,
charIeszhao,
gao-sun,
darcyYe and
simeng-li
charIeszhao
reviewed
Aug 16, 2022
charIeszhao
reviewed
Aug 16, 2022
charIeszhao
reviewed
Aug 16, 2022
charIeszhao
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
LGTM. However the PR title seems a little bit misleading. I was expecting to see a "fetch" function implementation, but only to find there were actually a set of encapsulated core OIDC APIs.
How about just core functions or to be more specific core functions to interact with OIDC APIs? You can decide. (I know I'm nit-picking again)
xiaoyijun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat(core): core fetch functions
Testing
UTs passed.