Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): handle signing out #11

Merged
merged 2 commits into from
Aug 23, 2022
Merged

feat(client): handle signing out #11

merged 2 commits into from
Aug 23, 2022

Conversation

xiaoyijun
Copy link
Collaborator

Summary

feat(client): handle signing out

  • Make props of the RevocationOptions public for they're used in the client package.

Testing

Test locally in web sample.

@xiaoyijun xiaoyijun self-assigned this Aug 22, 2022
@linear
Copy link

linear bot commented Aug 22, 2022

LOG-3876 Handle Sign Out

wangsijie
wangsijie approved these changes Aug 23, 2022
View reviewed changes
Copy link

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoyijun xiaoyijun merged commit 6674643 into master Aug 23, 2022
@xiaoyijun xiaoyijun deleted the xiaoyijun-log-3876-handle-sign-out branch August 23, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangsijie wangsijie wangsijie approved these changes

@IceHe IceHe Awaiting requested review from IceHe

@charIeszhao charIeszhao Awaiting requested review from charIeszhao

@gao-sun gao-sun Awaiting requested review from gao-sun

@darcyYe darcyYe Awaiting requested review from darcyYe

@simeng-li simeng-li Awaiting requested review from simeng-li

Assignees

@xiaoyijun xiaoyijun

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyijun @wangsijie