Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ECS-Compatibility Mode #48

Closed
yaauie opened this issue Feb 26, 2020 · 1 comment · Fixed by #50
Closed

Implement ECS-Compatibility Mode #48

yaauie opened this issue Feb 26, 2020 · 1 comment · Fixed by #50

Comments

@yaauie
Copy link
Contributor

yaauie commented Feb 26, 2020

This is a stub issue, and needs to be fleshed out with details specific to
this plugin.


As a part of the effort to make plugins able to run in an ECS-Compatible manner
by default in an upcoming release of Logstash, this plugin needs to either
implement an ECS-Compatibility mode or certify that it does not implicitly use
fields that conflict with ECS.

@andsel
Copy link
Contributor

andsel commented Jan 20, 2021

The only field added is the one the user selects with source_ip_fieldname which is host by default. The plugin extract the source IP and set that field is not yet present:

event.set(source_ip_fieldname, ip_address) if event.get(source_ip_fieldname).nil?

If the user customize the name is out of control of ECS but if the user leverage the default behaviour and has ecs_compatibility enabled we should switch that field to a new name [host][ip]. This rename could happen at register time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants