Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ua.os_name to ua.os_family or add a new ua.os_family field? #36

Open
anhlqn opened this issue Feb 10, 2017 · 1 comment
Open

Comments

@anhlqn
Copy link

anhlqn commented Feb 10, 2017

As discussed in this issue elastic/logstash#1669, is there any chance that we will either rename ua.os_name to ua.os_family or add a new ua.os_family and modify the patterns to capture only OS family (e.g. Microsoft, MacOS)?

Right now both ua.os and ua.os_name contain the same full OS names like Windows 7, Windows 8.

@untergeek
Copy link

If you want to submit a PR to change this, it appears that version 2.3.0 of the user_agent_parser Rubygem now supports family.

As many users may be expecting ua.os_name still, we'd be obliged to keep it and only add ua.os_family.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants