You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using this plugin in the company I work on, and we have the use case where we need both user agents: parsed and raw ones. We´re solving this issue by adding the raw user Agent as part of the array resulting of applying this plugin:
But, I wonder if this information is useful in other use cases, if so I can send you a pull request to add the raw user agent as part of the parsed array.
Thanks!
The text was updated successfully, but these errors were encountered:
Given the simplicity of your solution (using add_field), it feels like any alternate solution would be the same level of simplicity (adding one line to your config).
Maybe instead of patching the code, we add this as an example in the docs for this plugin, that if someone wants to store the original useragent text along with the parsed object, we could provide your example. Thoughts?
I was thinking about adding the source user agent once the target Hash is created, without end users to require any action. Anyway you're right, the "solution" is easy enough so that does not require patching the code.
Adding that example to the documentation looks fine to me.
@aramirez-es a pull request for the docs would be lovely :) - the docs for each plugin are as comments within the plugin itself, so adding some comment at the top of the class definition somewhere in this area would be good!
Hi guys,
I'm using this plugin in the company I work on, and we have the use case where we need both user agents: parsed and raw ones. We´re solving this issue by adding the raw user Agent as part of the array resulting of applying this plugin:
But, I wonder if this information is useful in other use cases, if so I can send you a pull request to add the raw user agent as part of the parsed array.
Thanks!
The text was updated successfully, but these errors were encountered: