Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the event hooks for requests include a status code? #1431

Closed
Midnighter opened this issue Jun 15, 2020 · 1 comment
Closed

Can the event hooks for requests include a status code? #1431

Midnighter opened this issue Jun 15, 2020 · 1 comment

Comments

@Midnighter
Copy link

Is your feature request related to a problem? Please describe.

It would be nice to not only be able to distinguish successful and failed requests but get slightly more information. I saw the request for the entire response and headers in #1413 and saw that you don't want that since it would be HTTP-specific. However, I was wondering if the same holds true for a status code, since that also applies to FTP and websockets at least. Maybe I am missing something, though.

@heyman
Copy link
Member

heyman commented Jun 17, 2020

If we were to change this I think we should add the whole response object like suggested in #1413, and then let custom clients add whatever metadata they want as additional arguments (while making sure that Locust itself never relies on any of the additional metadata).

Closing this but feel free to continue discussion in #1413.

@heyman heyman closed this as completed Jun 17, 2020
@heyman heyman added the wontfix label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants