Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramping.py calls RequestStats.sum_stats() which is no longer a valid call #104

Closed
einchance opened this issue Oct 29, 2013 · 3 comments
Closed

Comments

@einchance
Copy link

ramping.py attempts to call RequestStats.sum_stats() in 3 different places. This is no longer a valid call after the refactoring of the request statistics code

d1cc5ac

@Jahaja
Copy link
Member

Jahaja commented Oct 29, 2013

I'm not convinced that the parts related to ramping should remain in the Locust core. What do you guys think @cgbystrom @heyman?

I think it would probably be more appropriate as a plugin given that we could create a simple plugin architecture with such fine-grained control.

@heyman
Copy link
Member

heyman commented Nov 29, 2013

Since it's broken in the current version I think we should either fix it + document it, or cut it out. I'm leaning more towards cutting it out to keep the core features smaller, and hopefully be able to provide the possibility to add this kind of functionality through plugins in the future.

@Jahaja
Copy link
Member

Jahaja commented Nov 29, 2013

Fixed in e5ba814

@Jahaja Jahaja closed this as completed Nov 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants