Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Keycloak redirects to frontend which redirects to keycloak ad infinitum causing "ERR_TOO_MANY_REDIRECTS", #610

Closed
corneliusroemer opened this issue Nov 29, 2023 · 13 comments
Labels
auth authentication, authorization, incl. keycloak and keycloakify related issues bug Something isn't working website Tasks related to the web application
Milestone

Comments

@corneliusroemer
Copy link
Contributor

corneliusroemer commented Nov 29, 2023

I've noticed this both in a local test and on our main deployment: after succesfully logging in as testuser on keycloak, you get redirected back and forth infinitely leading to ERR_TOO_MANY_REDIRECTS

I've tried to reproduce now on main deployment after the first time I got the bug but I can't find ways to trigger it reliably. But here are some screenshots:

image

image

image

Potentially reproducible if logging out then clicking on user.

@corneliusroemer
Copy link
Contributor Author

corneliusroemer commented Nov 29, 2023

It happens in my main browser (Brave), but not in incognito. Can't reproduce in Chrome. Maybe some extension thing? But still something is up.

@fengelniederhammer
Copy link
Contributor

I also saw this on Firefox. I think something doesn't work as reliably as we thought. We'll definitely have to check this. But anyway we have to improve certain aspects of the whole login management in the browser anyway.

@fengelniederhammer fengelniederhammer added website Tasks related to the web application auth authentication, authorization, incl. keycloak and keycloakify related issues labels Nov 30, 2023
@corneliusroemer
Copy link
Contributor Author

Some pre-emptive logging in the middleware could help to figure out what's going on when someone manages to catch the issue.

@corneliusroemer
Copy link
Contributor Author

Just got that error again, when clicking "approve" on 28 sequences. Strange.

image

Now it happens for anything I click that requires authentication.

@corneliusroemer corneliusroemer added the bug Something isn't working label Dec 5, 2023
@corneliusroemer
Copy link
Contributor Author

Hit this error after a few clicks, following a standard test flow of submission, then navigating to revision.

@JonasKellerer
Copy link
Contributor

I thought a little about it and tried something in https://github.com/pathoplexus/pathoplexus/pull/653.
Could you check if your problem still occurs?

@JonasKellerer
Copy link
Contributor

It seems that the preview does not work here. I'm still looking at it.

@corneliusroemer
Copy link
Contributor Author

corneliusroemer commented Dec 12, 2023

Thanks for looking into this @JonasKellerer! Preview indeed gives me 500 after successful login on pages requiring authentication

@corneliusroemer
Copy link
Contributor Author

Is this fixed now by #638 or does this only add logging in this situation? @JonasKellerer

@chaoran-chen chaoran-chen added this to the MVP milestone Jan 5, 2024
@fengelniederhammer
Copy link
Contributor

Did this happen ever again or can we close this?

@chaoran-chen
Copy link
Member

I'll close this. @corneliusroemer, please reopen if this is still an issue!

@corneliusroemer
Copy link
Contributor Author

Yep no longer an issue!

@corneliusroemer
Copy link
Contributor Author

Now getting it again, related to #1090 which tries to fix #1087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth authentication, authorization, incl. keycloak and keycloakify related issues bug Something isn't working website Tasks related to the web application
Projects
Archived in project
Development

No branches or pull requests

4 participants