Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Excel files for metadata #3334

Open
emmahodcroft opened this issue Dec 2, 2024 · 2 comments · May be fixed by #3469
Open

Accept Excel files for metadata #3334

emmahodcroft opened this issue Dec 2, 2024 · 2 comments · May be fixed by #3469
Assignees
@fhennig
Labels
preprocessing Issues related to the preprocessing component website Tasks related to the web application

Comments

@emmahodcroft
Copy link
Member

A lot of people use Excel to handle and store metadata. Whether rightly or wrongly, it is what it is. We will lower the bar for upload significantly if we can support Excel metadata uploads.

We would probably need to force people to set the dates into ISO still, unless Excel encodes whether dates are US format or not (which it well might) to avoid confusion of whether 04/07/2022 is 7 of April or 4 of July.
@emmahodcroft emmahodcroft added website Tasks related to the web application discussion Open questions preprocessing Issues related to the preprocessing component labels Dec 2, 2024
@anna-parker
Copy link
Contributor

I fully agree, I think every beta tester we have talked to so far has raised this exact point, they use excel and would like more support for it

@fhennig fhennig mentioned this issue Dec 12, 2024
Closed
@fhennig
Copy link
Contributor

fhennig commented Dec 12, 2024 •
edited
Loading

Good point about the dates! I did the PoC now #3426 and looked into the docs of the library I used. It seems like excel internally stores date as an offset, the stuff seen in the UI is not actually stored in the file verbatim (source: SheetJS docs). The library seems to come with some date parsing support but I'm not sure which information you need to give it (i.e. which columns are dates?) -- would need to look into it more.

A technical note (already wrote here) - converting the file in the browser means we need to watch out for changes of the original file and then act on that (i.e. make the user re-submit the edited file).

This was referenced Dec 12, 2024
Closed
Open
@fhennig fhennig self-assigned this Dec 19, 2024
@fhennig fhennig removed the discussion Open questions label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhennig fhennig

Labels
preprocessing Issues related to the preprocessing component website Tasks related to the web application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(website): support excel metadata files in data upload form loculus-project/loculus
3 participants
@fhennig @emmahodcroft @anna-parker