Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate ESLint 8 to 9 #3069

Open
2 tasks
fhennig opened this issue Oct 24, 2024 · 1 comment
Open
2 tasks

chore: Migrate ESLint 8 to 9 #3069

fhennig opened this issue Oct 24, 2024 · 1 comment

Comments

@fhennig
Copy link
Contributor

fhennig commented Oct 24, 2024

I have disabled the dependabot upgrades for ESLint 9 for now: #3057

A move from 8 to 9 will have to include migrating to the new config format.

I have decided to track this in it's own issue, so we can prioritize doing this. Not sure if it's really that important.

We need to migrate the config file and the automatic migration tool doesn't work well for .js eslintrc files, so it'll be a manual effort.

links:

Tasks

  • migrate to the new config format first
  • then bump to the new major version
@corneliusroemer
Copy link
Contributor

Thanks! I've tried this before and decided we were blocked until eslint-plugin-import supports eslint9. I had a draft PR: https://github.com/loculus-project/loculus/pull/2472/files

Turns out that support has landed now: import-js/eslint-plugin-import#2948 so we're no longer blocked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants