From 3be6d17421858a406d2696fe733154eefcb6e30b Mon Sep 17 00:00:00 2001 From: Cornelius Roemer Date: Wed, 28 Feb 2024 21:45:26 +0100 Subject: [PATCH] No need to wait for particular images, kubernetes will retry pulling images and backoff if not found Given we build many docker images, we would otherwise wait for each - not just the 2 here. Instead, use timeout to fail if the images never make it. --- .github/workflows/e2e-k3d.yml | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/.github/workflows/e2e-k3d.yml b/.github/workflows/e2e-k3d.yml index 0bbff9e7f..fc1f040eb 100644 --- a/.github/workflows/e2e-k3d.yml +++ b/.github/workflows/e2e-k3d.yml @@ -81,26 +81,13 @@ jobs: run: cd website && npx playwright install-deps if: steps.playwright-cache.outputs.cache-hit == 'true' - - name: Wait for Backend Docker Image - uses: lewagon/wait-on-check-action@v1.3.3 - with: - ref: ${{ github.sha }} - check-name: Build Backend Docker Image - repo-token: ${{ secrets.GITHUB_TOKEN }} - - - name: Wait for Website Docker Image - uses: lewagon/wait-on-check-action@v1.3.3 - with: - ref: ${{ github.sha }} - check-name: Build Website Docker Image - repo-token: ${{ secrets.GITHUB_TOKEN }} - - name: Deploy with helm uses: WyriHaximus/github-action-helm3@v4 with: exec: ./deploy.py --verbose helm --branch ${{ github.ref_name }} --sha ${{ github.sha }} --dockerconfigjson ${{ secrets.GHCR_DOCKER_CONFIG }} - name: Wait for the pods to be ready + timeout-minutes: 10 run: ./.github/scripts/wait_for_pods_to_be_ready.py - name: Sleep for 20 secs run: sleep 20