Skip to content

Commit 59cf38d

Browse files
committed
remove activejob configuration and base class
Except for specific and relatively uncommon circumstances, Sidekiq has a perfectly sufficient API and commonly used conventions, and doesn't need an abstraction/wrapper around it.
1 parent 22f37dd commit 59cf38d

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

app/jobs/application_job.rb

-4
This file was deleted.

config/application.rb

-3
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ class Application < Rails::Application
1919
# -- all .rb files in that directory are automatically loaded after loading
2020
# the framework and any gems in your application.
2121

22-
# Use Sidekiq as ActiveJob backend
23-
config.active_job.queue_adapter = :sidekiq
24-
2522
# Configure generators, see: http://guides.rubyonrails.org/generators.html
2623
config.generators do |g|
2724
# Create appropriate tests in spec/ not test/

config/initializers/sidekiq.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#
66
# Client Size = Puma Workers * (Puma Threads / 2) * Heroku Web Dynos
77
#
8-
# Server Size = (Redis Connection Limit - Client Size - 2) / Heroku Job Dynos
8+
# Server Size = (Redis Connection Limit - Client Size - 2) / Heroku Worker Dynos
99
# Server Size is set in sidekiq.yml in concurrency setting.
1010
# Server size is concurrency + 2.
1111

0 commit comments

Comments
 (0)