-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various X bug fixes #435
Open
micahflee
wants to merge
12
commits into
main
Choose a base branch
from
432-error-indexing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Various X bug fixes #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is null, and reload mediaPath after the user successfully logs into X
…, isXAPIError, and isXAPIData
… really rated limited. This leads the indexing to stop early because it cannot find the retry button. Check to make sure this is not the case before looking for the retry button.
…rns clicking on and off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #432.
Also fixes #416, which I just realized was introduced in #384.
I also merged #434 and #430 into this branch, so we should review/merge those first.
For some reason, X returned a tweet (technically a RT) with entities that had
urls
that looked like this:While indexing, this now only saves URLs from tweets if all of the correct fields are present.
During indexTweets, X sometimes responds with 429 even when it is not really rated limited. This leads the indexing to stop early because it cannot find the retry button. This PR checks to make sure this is not the case before looking for the retry button, so the indexing doesn't stop early. I think this should make indexing more robust.
There were also various problems I noticed with saving DMs. When trying to save conversations it sometimes would timeout too soon and move to saving messages, so I increased the timeout. I fixed that by increasing the timeout, and also fiddling around with scrolling after the page loads to encourage it to show conversations. It seems to work.
I also added a "Enabling Clicking in Browser" link to the job status component. When you click it, you can click around in the browser during automation. If you click again, you can disable it.
It was difficult for me to reproduce, but I did get to a point when indexing DMs where there was a "retry" button that Cyd wasn't clicking and it was stuck, so this allows the user to click it themselves if they want.