-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple hosts filtering #5
Comments
we know that possibility to use request.host but this is not a good pratice, and can cause security issues. |
We could add multiple hosts in the WDYT? |
suggestions:
|
@ricardotealdi This can be a cool approach, we can auto detect the service key value type, and assume a default beheviour. |
+1 |
When there are multiple hosts actually the cache doesnt work, for example: |
@fagnerpereira Great point! There is a bug on the ticket caching. Even if we implement something to allow for multiple hosts, the ticket caching won't validate a different service/host. |
The ticket just be valid with our service, the cache key will should be a hash of key+service :p |
For an app that responds for multiple hosts (e.g.:
myapp.com
andapi.myapp.com
), theCassette::Authentication::Filter
doesn't allow us to configure more than one host for the service ticket validation.The text was updated successfully, but these errors were encountered: