Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Onnxruntime version and fix Windows compilerconfig #565

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

royshil
Copy link
Collaborator

@royshil royshil commented Mar 19, 2024

No description provided.

@royshil
Copy link
Collaborator Author

royshil commented Mar 20, 2024

@umireon we have a problem with onnxruntime 1.17.1 on linux where the .tgz file doesn't have the include/tensorrt_provider_factory.h
in v1.16.3 it did exist
i wonder if this file is no longer needed but TensorRT support still remains. it seems so because the .so file for tensorrt EP indeed exists in v1.17.1

@umireon
Copy link
Member

umireon commented Mar 20, 2024

@royshil SessionOptionsAppendExecutionProvider_TensorRT and SessionOptionsAppendExecutionProvider_TensorRT_V2 got to be included in onnxruntime_c_api.h so that we can safely remove the inclusion of include/tensorrt_provider_factory.h without any changes.

@royshil
Copy link
Collaborator Author

royshil commented Mar 20, 2024

@umireon the build is good - do you want to test or approve? thanks!

@royshil royshil merged commit cf5afb0 into main Mar 20, 2024
6 checks passed
@royshil royshil deleted the roy.bump_onnxruntime_1_17_1 branch March 20, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants